Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to solidjs#92.
This adds two tasks in
languages/reactivescript/tasks.json, which task: spawn offers while a.rxfile is open:rx-tsc: type-check projectrunsnpx --no rx-tsc --noEmitin the worktree root.rx-tsc: type-check project (watch)adds--watchand runs in its own terminal.Zed's extension docs don't mention
tasks.json. Its task docs do list language extensions as a source, though, andextension_host.rsloads the file from each language folder.Tasks don't use Zed's Node, and the extension's copy of the server isn't on the project's path. So the project needs
nodeon the PATH,@reactivescript/language-serverinstalled at the worktree root, and atsconfig.jsonwhoseincludenames the.rxfiles. Yarn PnP and a package that only lives in one sub-package of a monorepo aren't covered. The README says all of that.--nomakes sure nothing gets installed: without the package, npm reports a 404 forrx-tsc.I ran the command in a scratch project with the package installed through pnpm. It reported a wrong
:=write and exited 2. In a folder without the package it failed without installing anything. I haven't seen the tasks in Zed's picker yet.Based on
zed-rx, so the diff only shows this change.